I'm working on patch parsing support for JGit, so I can rely on it in Gerrit 2. Currently Gerrit 1 uses a bastard chunk of code I ripped out in an hour to scan the output of "git diff"; its not suitable for long-term appliction. This series improves RawParseUtils code clarity, and then adds support for the C-style quoting rules used by git diff when file names contain "special" characters like LF. I'm working on patch parsing right now; but I wanted to send this preliminary series out so you aren't drowning in code to review. Shawn O. Pearce (6): Simplify RawParseUtils.nextLF invocations Simplify RawParseUtils next and nextLF loops Correct Javadoc of RawParseUtils next and nextLF methods Add QuotedString class to handle C-style quoting rules Add Bourne style quoting for TransportGitSsh Add ~user friendly Bourne style quoting for TransportGitSsh .../jgit/util/QuotedStringBourneStyleTest.java | 111 ++++++ .../util/QuotedStringBourneUserPathStyleTest.java | 130 +++++++ .../spearce/jgit/util/QuotedStringC_StyleTest.java | 144 ++++++++ .../src/org/spearce/jgit/lib/ObjectChecker.java | 4 +- .../src/org/spearce/jgit/revwalk/RevTag.java | 2 +- .../spearce/jgit/transport/TransportGitSsh.java | 38 +-- .../src/org/spearce/jgit/util/QuotedString.java | 364 ++++++++++++++++++++ .../src/org/spearce/jgit/util/RawParseUtils.java | 45 ++- 8 files changed, 783 insertions(+), 55 deletions(-) create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringBourneStyleTest.java create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringBourneUserPathStyleTest.java create mode 100644 org.spearce.jgit.test/tst/org/spearce/jgit/util/QuotedStringC_StyleTest.java create mode 100644 org.spearce.jgit/src/org/spearce/jgit/util/QuotedString.java -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html