At Wed, 3 Dec 2008 00:36:12 +0100, Jakub Narebski wrote: Hello, > > This adds the GITWEB_GROUP_CATEGORIES option which, if enabled, will > > result in grouping projects by category on the project list page. > > Should this really be build time configuration (to set default value)? Probably not, I removed it. I corrected my patch using all your other comments and sent it again in another email. > Unfortunately it looks like you hit the edge of feature freeze again. Damn, time is always against me :-) Hope it's gonna be included eventually! > By the way, there was alternate patch series by Gustavo Sverzut Barbieri > on 29 July 2008 adding categories support to gitweb: > http://thread.gmane.org/gmane.comp.version-control.git/90553 > with live demo at http://staff.get-e.org/ Right, I saw that in July but it's not exactly the same feature (arbitrary category in config vs repository path). I think both are useful independently.. If both get supported, there should be a way to do it modularly to reuse code though. Btw you can see a demo of my patch here: http://inso.cc/git > Here is and important issue when adding categories support: how division > into categories interplays with sorting of projects. I kept it how it was but added a comment in the commitlog. > Another issue is how categories interplay with limiting number of > projects displayed. Currently it is no issue, because projects list > page is not divided into pages, but I think you didn't address this > in your patch. I think it's now better in v2, I added support for $from/$to also in the categorized project list. Thanks for your in depth comments, and I hope this patch will get applied in the near future! -- Sébastien Cevey / inso.cc " The question of whether a computer can think is no more interesting than the question of whether a submarine can swim. " Edsger W. Dijkstra -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
