Add backslash to list of 'crud' characters in real name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



We remove crud characters at the beginning and end of real-names so that 
when we see email addresses like

	From: "David S. Miller" <davem@xxxxxxxxxxxxx>

we drop the quotes around the name when we parse that and split it up into 
name and email.

However, the list of crud characters was basically just a random list of 
common things that are found around names, and it didn't contain the 
backslash character that some insane scripts seem to use when quoting 
things. So now the kernel has a number of authors listed like

	Author: \"Rafael J. Wysocki\ <rjw@xxxxxxx>

because the author name had started out as

	From: \"Rafael J. Wysocki\" <rjw@xxxxxxx>

and the only "crud" character we noticed and removed was the final 
double-quote at the end.

We should probably do better quote removal from names anyway, but this is 
the minimal obvious patch.

Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
---
 ident.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/ident.c b/ident.c
index 09cf0c9..99f1c85 100644
--- a/ident.c
+++ b/ident.c
@@ -121,6 +121,7 @@ static int crud(unsigned char c)
 		c == '<' ||
 		c == '>' ||
 		c == '"' ||
+		c == '\\' ||
 		c == '\'';
 }
 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux