Johannes Sixt schrieb: > Mike Ralphson schrieb: >> 2008/11/17 Johannes Sixt <j.sixt@xxxxxxxxxxxxx>: >>> Mike Ralphson schrieb: >>>> 2008/11/15 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>: >>>>> On Sat, 15 Nov 2008, Junio C Hamano wrote: >>>>>> This introduces make variable NO_PTHREADS for platforms that lack the >>>>>> support for pthreads library or people who do not want to use it for >>>>>> whatever reason. When defined, it makes the multi-threaded index >>>>>> preloading into a no-op, and also disables threaded delta searching by >>>>>> pack-objects. >>>>> Ack. Makes sense. >>>> I'd be minded to make this the default on AIX to keep the prerequisite >>>> list as small as possible, then people can opt-in for the performance >>>> benefits if required. >>> Is pthreads not a standard shipment on AIX? I would set NO_PTHREADS only >>> if we know in advance that there are many installations without pthreads. >>> (And I don't know what the situation is.) >> I should have dug a bit further, it seems to be present on my 5.3 >> machines but I still need to determine whether it got installed by >> default. Either way it must need some other link flags... > > I tried compiling with THREADED_DELTA_SEARCH=Yes, and it fails with > > CC builtin-pack-objects.o > In file included from /usr/include/sys/pri.h:29, > from /usr/include/sys/sched.h:38, > from /usr/include/sched.h:52, > from /usr/include/pthread.h:43, > from builtin-pack-objects.c:22: > /usr/include/sys/proc.h:203: parse error before "crid_t" > /usr/include/sys/proc.h:212: parse error before "p_class" > /usr/include/sys/proc.h:355: parse error before '}' token > > :-( Maybe NO_PTHREADS is indeed the safer choice? I'm not going to dig > into this today, though. (I'm on AIX 4.3.something.) > >>> BTW, this needs to be squashed in, because we don't have pthreads on Windows: >>> >>> diff --git a/Makefile b/Makefile >>> index ffc9531..3a30b8c 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -769,6 +769,7 @@ ifneq (,$(findstring MINGW,$(uname_S))) >>> NO_STRCASESTR = YesPlease >>> NO_STRLCPY = YesPlease >>> NO_MEMMEM = YesPlease >>> + NO_PTHREADS = YesPlease >>> NEEDS_LIBICONV = YesPlease >>> OLD_ICONV = YesPlease >>> NO_C99_FORMAT = YesPlease >>> >> Ta. Ok to add your S-o-B on a squashed patch? > > Sure. Use this address please: > > Signed-off-by: Johannes Sixt <j6t@xxxxxxxx> Mike, you said you would resend the patch, but I think you forgot about it. Would you do that now, please? -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
