Re: [PATCH 3/3] gitweb: make gitweb_check_feature a boolean wrapper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Giuseppe Bilotta" <giuseppe.bilotta@xxxxxxxxx> writes:

> On Sat, Nov 29, 2008 at 10:16 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>  * Again, this is to demonstrate how I would have liked to see your
>>   patches as a reviewable series.  Notice how this naturally justifies
>>   the dropping of parentheses in many lines that begin with "my", and
>>   makes it easier to review?  You can review the patch easily by knowing
>>   that callers that have s/get/check/ are now safe to use scalar context.
>
> Yes, I get the point: do less things under the hood. I also still
> think that three patches with code going ping-pong are way too much,
> though 8-P
>
> For what it's worth, you get my Ack: to your patchset 8-)

Well, I am not interested in taking credits for this series.  I am very
much interested in reducing my future workload by showing people how an
easily reviewable series should look like.

So if you still think it is "way too much", I did not succeed what I tried
to do X-<.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux