Re: [PATCHv2ter 2/2] gitweb: clean up gitweb_check_feature() calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Giuseppe Bilotta" <giuseppe.bilotta@xxxxxxxxx> writes:

> And this is precisely the reason why the first time I sent the patch I
> did the restyling in the same go: by not touching the
> clueless/careless callers and instead bringing gitweb_check_feature to
> act in scalar context, it would automatically fix those broken usages,

... which is very bad for reviewability purposes.

By explicitly fixing them before doing the "this will sweep all the
potential bugs under the rug", you can demonstrate a lot more clearly why
these changes are necessary.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux