Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > On Thu, 27 Nov 2008, Junio C Hamano wrote: > > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > > > I have a strong suspicion that the narrow stuff will make the worktree > > > mess pale in comparison. > > > > > > Note that I do not have time to review this myself (which is not > > > helped at all by it being no longer a trivial single patch, but a full > > > 10 patches!), but I really have a bad feeling about this. IMO it is > > > substantially under-reviewed. > > > > Well, "a bad feeling" is not a convincing enough argument either, is it? > > What kind of bad interaction are you fearing? ... > And the worst part: I think that as with worktree, there has not been > enough of kicking forth and back ideas how to design the beast, so I fully > expect a subtle breakage that would require a redesign (which will be > painful, with existing users of the feature). > > Maybe I am crying "wolf", but I _do_ want to caution against risking too > much, too fast, with that feature. > > In other words, unless there is more interest in that feature, enough to > generate a well-understood design before a good implementation, I'd rather > see this patch series dropped. Ack. I agree with every remark made by Dscho, and also want to cry "wolf". I haven't had time to read the patch series. Its big and intrusive and I just don't need the feature. But I feel like if it were in fact merged I'll fall over some bug in it sometime soon and be forced to stop and debug it. Heck at the least I'll have to go back to JGit's index code and implement the new file format. That shouldn't cause git.git's development to stop, but I am whining (a little) about the file format change. ;-) -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
