On Sun, Nov 23, 2008 at 07:51:36PM -0800, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Can't this be done much earlier? This variable can potentially be > assigned to work_tree, but after we set up the atexit handler neither dir > nor work_tree are not used (it is a bit hard to see as this function > itself is a bit too big to be maintainable). Hm, reading the code again I think you should just drop 1/4. work_tree is a pointer to dir, and junk_work_tree is a pointer to work_tree. junk_work_tree is used in the signal handler, so it has to be allocated during the whole clone. I guess it was just an accident that my patch passed the tests. Sorry for the mistake.
Attachment:
pgpoMkzTSeeu5.pgp
Description: PGP signature
