Re: [RFC/PATCH] bisect: teach "skip" to accept special arguments like "A..B"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, 23 Nov 2008, Christian Couder wrote:

> The current "git bisect skip" syntax is "git bisect skip [<rev>...]"
> so it's already possible to skip a range of revisions using
> something like:
> 
> $ git bisect skip $(git rev-list A..B)
> 
> where A and B are the bounds of the range we want to skip.
> 
> This patch teaches "git bisect skip" to accept:
> 
> $ git bisect skip A..B
> 
> as an abbreviation for the former command.
> 
> This is done by checking each argument to see if it contains two
> dots one after the other ('..'), and by expending it using
> "git rev-list" if that is the case.

s/expend/expand/

> Note that this patch will not make "git bisect skip" accept all
> that "git rev-list" accepts, as things like "^A B" for exemple
> will not work. But things like "A B..C D E F.. ..G H...I" should
> work as expected.
> 
> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
> ---
>  git-bisect.sh |   19 ++++++++++++++++++-
>  1 files changed, 18 insertions(+), 1 deletions(-)
> 
> 	Dscho wrote:
> 	> Would it not be more intuitive to have support for
> 	>
>         > git bisect skip A..B
> 	>
> 	> ?
> 
> 	Here is a patch to do that. I am not sure it's worth it
> 	because this is a special case in many ways.

Why not have something like

	skip)
		for arg in $(git rev-list "$@")
		do
			bisect_state skip $arg
		done

?

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux