On Thu, Nov 20, 2008 at 15:34, Petr Baudis <pasky@xxxxxxx> wrote: > On Thu, Nov 20, 2008 at 02:57:10PM +0100, Jonas Fonseca wrote: >> When output is not redirected to a file, git brings up the pager for >> only the diff, which can be confusing, so disable with --no-pager. >> git-diff is a porcelain command and thus subject to color options. Use >> --no-color, to avoid the patch being corrupted with terminal escape >> characters when color.diff=always. >> >> Signed-off-by: Jonas Fonseca <fonseca@xxxxxxx> > > I still don't understand how did that color thing happen - shouldn't > git diff avoid spewing out colors when the output is not a tty? And when > it is, I want the colors myself, too. As I wrote in the commit message, git diff always spews out colors with color.diff=always. This was what I for experimental reasons had in my .git/config (and forgotten all about) before sending the README update patch. Topgit could check the git color configuration but that seems more hacky. > Good point with the --no-pager, but in that case, tg patch itself should > by default invoke the pager, since it really is very desirable. Yes, probably. -- Jonas Fonseca -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
