Junio C Hamano <gitster@xxxxxxxxx> writes: > Jeff King <peff@xxxxxxxx> writes: > >> On Wed, Oct 01, 2008 at 11:04:05AM +0700, Nguyễn Thái Ngọc Duy wrote: >> >>> +test_expect_success 'setup' ' >>> + mkdir sub && >>> + touch 1 2 sub/1 sub/2 && >>> + git add 1 2 sub/1 sub/2 >> >> Mind-boggling, but this manages to break on Solaris. Fix is >> below. > > I tend to avoid "touch", not specifically for this reason, but surely this > is another reason why ">sub/1" is much better way to create a throw-away > file ;-) > >> Note that this has implications for 'touch "$FOO" "$BAR"' >> used in scripts if FOO might be entirely numeric. However, a >> quick grep shows we usually touch one file at a time. > > You can always do: > > : >>"$FOO" Having said all that, I wouldn't suggest redoing the patch using >> redirection. But change from "touch 1 nondigit" to "touch nondigit 1" is a bit too subtle to my taste. Let's write it this way instead: diff --git a/t/t2104-update-index-no-checkout.sh b/t/t2104-update-index-no-checkout.sh index be9f913..37a6861 100755 --- a/t/t2104-update-index-no-checkout.sh +++ b/t/t2104-update-index-no-checkout.sh @@ -9,7 +9,7 @@ test_description='git update-index no-checkout bits (a.k.a sparse checkout)' test_expect_success 'setup' ' mkdir sub && - touch 1 2 sub/1 sub/2 && + touch ./1 ./2 sub/1 sub/2 && git add 1 2 sub/1 sub/2 ' -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
