crquan@xxxxxxxxx writes:
> From: Cheng Renquan <crquan@xxxxxxxxx>
>
> Pass the verbose mode parameter to the underlying fetch command.
>
> $ ./git remote -v update
> Updating origin
> From git://git.kernel.org/pub/scm/git/git
> ...
> Signed-off-by: Cheng Renquan <crquan@xxxxxxxxx>
> ---
> So now the patch looks very simple.
Indeed it does ;-), but there still is a minor nit.
> + "git remote update [-v | --verbose] [group]",
Notice the difference between the example in your commit log message and
the help text?
I think "git remote [options] [cmd] [more options]" which is the current
option parser seems to try doing is very misguided, and a longer term
fix-up might be to redo the cmd_remote() option parser, but in the short
term, let's apply your patch with the following minor fixup:
diff --git c/builtin-remote.c w/builtin-remote.c
index 0af742b..abc8dd8 100644
--- c/builtin-remote.c
+++ w/builtin-remote.c
@@ -14,7 +14,7 @@ static const char * const builtin_remote_usage[] = {
"git remote rm <name>",
"git remote show [-n] <name>",
"git remote prune [-n | --dry-run] <name>",
- "git remote update [-v | --verbose] [group]",
+ "git remote [-v | --verbose] update [group]",
NULL
};
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
