On 11/8/08, Junio C Hamano <gitster@xxxxxxxxx> wrote:> Yann Dirson <ydirson@xxxxxxxxxx> writes:>> > On Fri, Nov 07, 2008 at 09:35:32PM +0700, Nguy???n Thái Ng???c Duy wrote:> >> This patch teaches diffcore_rename() to look into> >> $GIT_DIR/rename-cache and make use of it to recreate diff_filepair.> >> With proper cache, there should be no available entry for estimation> >> after exact matching.> >> > This is something I have thought about in the past, good to see that> > implemented :)> >> >> Rename caching is per commit. I don't think abitrary tree-tree caching> >> is worth it.> >> > That could be a nice complement to my directory-rename patch.>>> Has anybody thought about interaction between that caching and pathspec> limited operation?>
I didn't. But I think all out-of-pathspec diff pairs are removedbefore it reaches diffcore_rename() so the cache has nothing to dowith it (except it still loads full cache for a commit).-- Duy��.n��������+%������w��{.n��������n�r������&��z�ޗ�zf���h���~����������_��+v���)ߣ�m
