Baz <brian.ewins@xxxxxxxxx> writes: > 2008/10/30 Yann Dirson <ydirson@xxxxxxxxxx>: > > Rename factorization tries to group together files moving from and to > > identical directories - the most common case being directory renames. > > This feature is activated by the new --factorize-renames diffcore > > flag. > > Sorry to bikeshed a bit here, but this isn't what 'factorize' means, > and adding a flag with this name unnecessarily adds to the > git-specific terms users have to learn. Well, I think from _mathematical_ (arithmetic) point of view it makes perfect sense. Before you had: (rename-of-sub1-file1 rename-of-sub1-file2 rename-of-sub1-file3) and after you have (rename-of-sub1) * (changes in files) > Looking back through the archives, there's only a few people who've > used the word 'factorize', and /mostly/ it seems to have been used as > a synonym for 'refactor' in comments; not common usage but > understandable. However in this case, factorize is being used in the > opposite sense from its dictionary definition - to break down into > factors - and instead is being used to mean to /combine/ things; I > don't think that should be in the UI. > > Why not just '--group-renames'? That said, I think that '--group-renames' makes better sense (and is shorted than '--detect-directory-renames') +1 for '--group-renames' -- Jakub Narebski Poland ShadeHawk on #git -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
