Alexander Gavrilov wrote: > [...] it is necessary to declare all global > variables as 'our' [...] > > Signed-off-by: Alexander Gavrilov <angavrilov@xxxxxxxxx> I have forgot about that when reviewing path_info patches. I'm sorry about that. Good catch, and good explanation. Acked-by: Jakub Narebski <jnareb@xxxxxxxxx> > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index c5254af..2174d4a 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl [...] > -my $path_info = $ENV{"PATH_INFO"}; > +our $path_info = $ENV{"PATH_INFO"}; [...] -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html