On Tue, Nov 04, 2008 at 09:57:43PM +0100, Clemens Buchacher wrote: > On Mon, Nov 03, 2008 at 11:26:44PM -0500, Jeff King wrote: > > Nit: Just reading the test, it is hard to see what is interesting about > > it (though obviously I can blame it back to your commit :) ). Maybe a > > more descriptive title like 'push updates uptodate local refs' would > > make sense. > > That is all I changed in this update. Pending an Ack/Nack from Jeff I feel > that I'm done. I have to NAK, because the extra written ref is still a problem (see my other mail). But with that fix (and I hope you both will agree with the style fixup on removing new_sha1, too), I think it should be good. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html