2008/10/31 Jeff King <peff@xxxxxxxx>: > On Fri, Oct 31, 2008 at 01:09:13AM -0400, Brian Gernhardt wrote: > >> Not all /bin/sh have a builtin echo that recognizes -n. Using printf >> is far more portable. >> >> Discovered on OS X 10.5.5 in t4030-diff-textconv.sh and changed in all >> the test scripts. > > Hmph. I think this is a good patch, and there is precedent in the past > (20fa04ea, 2aad957, 9754563). But I am surprised this was not caught by > our recent autobuilding project. > > However, it seems to work on FreeBSD (which makes it doubly weird that > it is broken on OS X). On Solaris, the /bin/sh is so horribly broken > that I have to use bash anyway. Commit 9754563 claims breakage on AIX, > but it looks like Mike is doing the AIX builds with bash. I've just retested with AIX's standard sh (ksh) instead of bash and there were only two issues. Oddly enough, one was with the (original) printfs in t4030-diff-textconv.sh. AIX seems to ship with a perfectly good printf, but if you install the GNU tools from the 'IBM toolbox for AIX' (and prepend them to your PATH) it replaces that printf with one which doesn't grok the "\\1\\n" syntax, but I think wants it to be "\\01\\n". The other problem is the 'trap exit' one discussed here: http://thread.gmane.org/gmane.comp.version-control.git/92748/focus=92944 Mike -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
