Junio C Hamano <gitster@xxxxxxxxx> wrote: > "Jan Krüger" <jk@xxxxx> writes: > > > Can I then delete the branch afterwards without lots of juggling (in > > case the test fails due to a random other reason that the branch > > accidentally getting deleted by receive-pack)? I'd expect I'd have to > > save the exit code to a temporary variable and that's just as ugly. If you want to delete the branch after the test is done, do it outside of the test_expect_success's 3rd argument. Then it will run the branch deletion whether or not the test was successful. > Although I agree that your attempt to allow the test continue even when > this test fails is a very good practice, I personally do not find the > alternative you mention ugly at all. I actually find that "return 1" > uglier because it feels like it knows too much about how > test_expect_success is implemented. Yea, I also found the "return 1" to be horribly difficult to read, and knowing far too much about the test suite. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
