Re: [PATCH 1/2] Add --verbose|-v to test-chmtime

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 30, 2008 at 12:26:24PM +0100, Alex Riesen wrote:

> This allows us replace perl when getting the mtime of a file because
> of time zone conversions, though at the moment only one platform which
> does this has been identified: Cygwin when used with ActiveState Perl
> (as usual).
> [...]
>     test-chmtime -v +0 filename1 | cut -f 1

Personally, I would have:

  - split the argument refactoring and the addition of the "-v" argument
    into two patches to make reviewers lives easier

  - just used a special timespec that means "don't change anything, but
    show show"

but I think those are mostly nitpicks, so I am OK with the series as-is.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux