2008/10/28 Junio C Hamano <gitster@xxxxxxxxx>: > Nanako Shiraishi <nanako3@xxxxxxxxxxx> writes: >> Quoting Junio C Hamano <gitster@xxxxxxxxx>: >> >>> This is the answer to the question I asked in: >>> >>> http://thread.gmane.org/gmane.comp.version-control.git/97986/focus=98066 >>> >>> Perhaps we should use a separate variable as the original patch did, in: >>> >>> http://article.gmane.org/gmane.comp.version-control.git/97987 >>> >>> How about doing it like this instead? >> >> Junio, may I ask what the status of this patch is? I see you did not write tests nor commit message --- are you waiting for others to write them? > > Heh, Alex's ack is good enough for me as far as the code itself is > concerned, but I do want these "fixes" accompanied by additional tests to > reproduce to avoid future regressions, and this being a Cygwin fix, I am > not really the right person to write tests nor run them. I suggest NOT writing the test for the workaround for just one platform I personally call the most idiotic of the Microsoft's fallouts. As the fix is located in the code specific to that platform, it wont do any harm for anyone, whether it works or not (even if the code in tree does not work). The Junio's fix is definitely enough for me and, I'm very sure, for anyone still having to deal with cygwin. So for the Google's record: the patch to fix the --encoding option of git format-patch broken on cygwin is in the Junio's mail, to be found, i.e.: http://marc.info/?l=git&m=122482769817566&w=4 Nanako, as there is not many of such poor bastards left, it is not even a problem to keep the fix just in Git mailing list archives. There is just not enough of a looser base to press its development in whatever direction. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
