Hi, Please apply this compatibility fix (commit v1.6.0.1-90-g27a6ed4) to maint as well. On Sun, Aug 24, 2008 at 11:23:25PM +0300, Tommi Virtanen wrote: > >From 8e7935231e8a91d470b3a4a2310803031ef49fc4 Mon Sep 17 00:00:00 2001 > From: Tommi Virtanen <tv@xxxxxxxxxx> > Date: Sun, 24 Aug 2008 23:20:33 +0300 > Subject: [PATCH] Install git-shell in bindir, again. > > /etc/passwd shell field must be something execable, you can't enter > "/usr/bin/git shell" there. git-shell must be present as a separate > executable, or it is useless. > > Signed-off-by: Tommi Virtanen <tv@xxxxxxxxxx> > --- > > Hi. Recent changes moved away from "git-foo" to "git foo", except for > some commands that needed backwards compatibility. However, git-shell > as a separate binary was removed. I hope you will reinstante git-shell > as a publicly visible binary in bin. Here's why: > > The shell field in /etc/passwd is *exec*ed, not interpreted via sh -c > or some such. For example, source of Debian's shadow, containing > /bin/login: > > libmisc/shell.c:80: execle (file, arg, (char *) 0, envp); > > I also tested this for real, and having a > > test:x:1001:1001:,,,:/home/test:/usr/bin/git-shell > > line works, and > > test:x:1001:1001:,,,:/home/test:/usr/bin/git shell > > just makes ssh loop asking for a password, logging > > "User test not allowed because shell /usr/bin/git shell does not exist" > > So, as far as I understand, as it currently is, "git shell" is utterly > useless for what it was meant to do. Restoring "git-shell" will fix > it. > > Makefile | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile b/Makefile > index 53ab4b5..24d5809 100644 > --- a/Makefile > +++ b/Makefile > @@ -1351,7 +1351,7 @@ install: all > $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(bindir_SQ)' > $(INSTALL) -d -m 755 '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' > $(INSTALL) $(ALL_PROGRAMS) '$(DESTDIR_SQ)$(gitexec_instdir_SQ)' > - $(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X '$(DESTDIR_SQ)$(bindir_SQ)' > + $(INSTALL) git$X git-upload-pack$X git-receive-pack$X git-upload-archive$X git-shell$X '$(DESTDIR_SQ)$(bindir_SQ)' > $(MAKE) -C templates DESTDIR='$(DESTDIR_SQ)' install > $(MAKE) -C perl prefix='$(prefix_SQ)' DESTDIR='$(DESTDIR_SQ)' install > ifndef NO_TCLTK > -- > 1.6.0.2.g2ebc0.dirty -- ldv
Attachment:
pgpjY9YP6wAHX.pgp
Description: PGP signature
