Re: Re* ext3: fix ext3_dx_readdir hash collision handling - Regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes:

> On Fri, 24 Oct 2008, Junio C Hamano wrote:
>>
>> Subject: allow readdir(3) to return the same entry twice
>
> The thing is, this really is a kernel bug. We have even bisected it (and 
> it hasn't hit any released kernel). The original reporter showed it with a 
> simple "rm -r".
>
> So it really isn't a git bug, even though I initially thought it might be, 
> before I looked closer.
>
> That said, the git patch may be worth it just because two *concurrent* 
> invocations of "git clean" could then cause one (or both) to fail this 
> way.

Yeah, or on perhaps a buggy implementation of readdir(3) on somebody
else's system.  In either case, I just thought it might be a low impact
belt-and-suspenders fix that is worth considering.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux