On Fri, Oct 24, 2008 at 09:15:54AM +0200, Johannes Sixt wrote: > What do we do when symlinks are involved? Pilot error? Or should we > exclude them from textconv (and diff.*.command, for that matter) > at all times? See a test case below. Hrm, I hadn't really considered that. I would guess they should not be excluded from diff.*.command; the external driver gets the mode, so it is free to represent symlinks in whatever way it wants. But clearly they are going to always be text, so there is no point in textconv'ing them. > +cat >expect.typechange <<'EOF' > +Binary files a/file and /dev/null differ > +diff --git a/file b/file > +new file mode 120000 > +index ad8b3d2..67be421 > +--- /dev/null > ++++ b/file > +@@ -0,0 +1 @@ > ++frotz > +\ No newline at end of file > +EOF > + I find this output a bit confusing, since it actually breaks it into a deletion and an addition. But I guess that is orthogonal to the textconv issue, and intended. I don't think I've ever actually needed to diff a symlink before. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
