On Thu, Oct 23, 2008 at 12:13:47AM +0200, Johannes Schindelin wrote: > I wonder if it would not be better to scrap the t/valgrind/ directory and > regenerate it everytime you run a test manually; Yeah, I mentioned that in my 0/5 cover letter. The problem is where to put it that won't impact test results, but also allow running multiple tests simultaneously. I'm going to try sticking it in .git/valgrind in the trash directory, which presumably won't affect any tests. > I'd use "ln" instead of "cp" I specifically stayed away from 'ln' for Windows portability. It looks like for builtins, we do "ln || ln -s || cp". We can probably do the same here. I also failed to use git$X in the fake path, which would probably be necessary for Windows. > and also parse command-list.txt to catch really all of them (even if > a dashed form is used for a builtin by mistake). That is a little bit trickier. I don't actually want to intercept git-am, for example, since I have no interest in running valgrind on the shell. But it is do-able; I will give details in my response to Junio's suggestion. > Otherwise: good work, I like it! Thanks. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
