On Wed, Oct 22, 2008 at 12:07:48PM -0700, Junio C Hamano wrote: > Yuck. Solaris 8 /usr/bin/grep does not even grok "-e", so we cannot do a > more obvious: > > grep -e "^author " -e "^summary " Yep. I already introduced one use of egrep for a similar case in 8753941 (tests: grep portability fixes). > Do people build with NO_EXTERNAL_GREP on older Solaris? Yep. See: http://repo.or.cz/w/git/gitbuild.git?a=blob;f=jk/solaris/config.mak;hb=platform for the gory details (boy, I wish we had nice PATH_INFO-based gitweb URLs...). > git-submodule.sh uses grep "-e" to look for two patterns and I suspect > older Solaris would have the same issue. Yes, that code will break on Solaris. Most of my portability fixes have been in direct response to tests, so I guess we are not testing git-submodule very well. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
