On Tue, Oct 21, 2008 at 1:54 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > "Tuncer Ayaz" <tuncer.ayaz@xxxxxxxxx> writes: > >> On Sun, Oct 19, 2008 at 11:26 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> ... >>>> @@ -23,6 +24,10 @@ rebase=$(git config --bool branch.$curr_branch_short.rebase) >>>> while : >>>> do >>>> case "$1" in >>>> + -q|--quiet) >>>> + verbosity="$verbosity -q" ;; >>>> + -v|--verbose) >>>> + verbosity="$verbosity -v" ;; >>> >>> You know verbosity flags (-q and -v) are "the last one wins", so I do not >>> see much point in this concatenation. >> >> Without concatenation I would need to analyze the content >> of the variable each time the option is passed to the shell >> script. Do you know of a simpler/better way still keeping the >> functionality that >> $ git pull -q -v --quiet --verbose --quiet gives verbosity=QUIET >> and >> $ git pull -q -v --quiet --verbose --quiet -v yields verbosity=VERBOSE >> ? > > Wouldn't > > verbosity= > while : > do > case "$1" in > -q|--quiet) verbosity=-q ;; > -v|--verbose) verbosity=-v ;; > ... others ... > esac > shift > done > git pull $verbosity other options > > give the -q for the former and -v for the latter to "git pull"? Yes that is much simpler and works :). Thanks. Please see my next patch in a few minutes. I might not reply before the weekend as I'm pretty busy, btw. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
