On Fri, 17 Oct 2008, Junio C Hamano wrote: > Daniel Barkalow <barkalow@xxxxxxxxxxxx> writes: > > > On Thu, 16 Oct 2008, Junio C Hamano wrote: > > > >> The patch to branch.c is a quick fix for this issue. The resulting code > >> passes all the tests, but I am not very proud of hardcoding the "HEAD" in > >> the code. There must be a better way to do this. > > > > I agree with the change to the test. I think it would be better to > > hard-code "refs/heads/" instead of "HEAD", and I feel like we must have a > > "is this ref name a branch?" function, if only because someone could stick > > "refs/tags/foo" in HEAD, and we should still say it's not something you > > could track, despite it being something different from "HEAD". > > But you can track things under refs/remotes/, so... Ah, true. Maybe hard-code "refs/". Or have an "is this ref name a branch?" function that's paying more attention than I am, and returns true from both local branches and (local copies of) remote branches. -Daniel *This .sig left intentionally blank* -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
