Anders Melchiorsen <mail@xxxxxxxxxxxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> That documentation is quite loosely written. Typechange diff is what >> T has always meant, and it never was about the executable bit. The >> word "mode" in that sentence only means the upper bits >> S_IFREG/S_IFLNK (iow, masked by S_IFMT). > > I hope you agree that this reading is not obvious from the > documentation,... Yup, didn't I already say that the documentation is buggy? > How about adding a diff-filter=X for the executable bit? I do not think it is a good idea for two reasons. Backward compatibility and sane design. For one thing, "diff --name-status" never shows X, so you would introduce an unnecessary inconsistency. If you change "--name-status" to avoid that, you would be breaking people's existing scripts that expect to see "M" for such a change. Even if you were forgiven by these people whose scripts are broken by your change, you need to decide between "M" and "X" when both contents and executable bit are changed. The least surprising logic would probably be to show "X" when _only_ executable bit is changed and show "M" when contents changed (even when executable bit also did), but that feels quite arbitrary. And the other way around isn't any better. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
