On Wed, 2008-10-15 at 22:23 -0700, Junio C Hamano wrote: > Johannes Sixt <j.sixt@xxxxxxxxxxxxx> writes: > > We have to decide case by case. In the case of shared directories it makes > > sense to suggest "do not play ACL games". In other cases, however, this > > suggestion could not work out that well, and a workaround in the code is > > the better solutions. But we do not know what those other cases are, and > > the test suite may be a tool to uncover them. > > Although I am not particularly interested in hypothetical case that does > not have concrete examples, I do not care deeply enough either. So let's > take this patch (with updated/corrected log message) that minimally covers > the parts that can be broken by ACL games. As I said in my other message, default ACLs do not break git, they only break the way git is being tested in t1301-shared-repo.sh . There is no cause for concern. In fact, default ACLs obsolete core.sharedrepository as a means of setting default permissions on a repository because default ACLs apply to files created by any program while core.sharedrepository is recognized only by git. Thus, a user who has a default ACL would be unlikely to also have core.sharedrepository, so even if there were a bad interaction between the two, no one would be likely to encounter it. Updated patch to follow. Matt -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
