2008/10/15 Junio C Hamano <gitster@xxxxxxxxx>: > Alex Riesen <raa.lkml@xxxxxxxxx> writes: > >> Junio C Hamano, Wed, Oct 15, 2008 01:17:52 +0200: >>> "Alex Riesen" <raa.lkml@xxxxxxxxx> writes: >>> > >>> > Otherwise the function sometimes fail to resolve obviously correct refnames, >>> > because the string data pointed to by "ref" argument were reused. >>> > >>> But your patch instead rewrites the computation of str2 by bypassing the >>> call to "another_function_that_uses_get_pathname()" and duplicating its >>> logic, which I do not think is a viable approach in the longer term. >> >> There is not enough logic to bypass there. It's just a dumb sprintf! > > But didn't you lose call to cleanup_path()? > In this case? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
