Alexander Gavrilov writes: > Since git apparently cannot work with filenames in non-locale > encodings anyway, I did not try to do anything about it apart > from fixing some obvious bugs. What we did before was read filenames and convert them from the system encoding (done implicitly by gets) before unquoting filenames that were quoted. What we do now with your patch 1/2 is that we read the filenames in binary and unquote any quoted filenames before converting from the system encoding. So I don't think your patch would have made as much difference as it might appear. If there is a reason for unquoting before converting from the system encoding rather than after, it seems pretty subtle to me and wasn't explained in the patch description. An explanation, preferably with examples, would be useful. Also, you didn't say whether you found the "obvious bugs" by inspection or by encountering their effects in actual running (and if so, what those effects were). That information is also good to have in the patch description. Paul. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
