On Tue, Oct 14, 2008 at 07:00:27PM -0400, Matt McCutchen wrote: > On Tue, 2008-10-14 at 15:32 -0700, Junio C Hamano wrote: > > Makes me wonder why this is _not_ inside test-lib.sh where it creates the > > test (trash) directory. That way, you would cover future tests that wants > > to see a saner/simpler POSIX permission behaviour, wouldn't you? > > Yes. However, I don't anticipate there being any tests specifically > about file permissions other than t1301-shared-repo.sh, and if the user > has set a default ACL on the git source tree, we might want to let trash > directories obey that setting except in the one case where it breaks the > test. What do you think? I'll add a shameless plug for my patch: Fix testcase failure when extended attributes are in use, available from Gmane at http://thread.gmane.org/gmane.comp.version-control.git/98170 It's orthogonal to this patch, I think: this patch deals with ACLs overriding the umask testing we're doing, while my patch deals with parsing the permissions that ls returns, and applies to instances where extended attributes are in use which we can't get rid of, like SELinux. Deskin Miller -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
