Err... "*** SUBJECT HERE ***"? Not that it matters... On Mon, 13 Oct 2008, Giuseppe Bilotta wrote: > Fifth attempt for my gitweb PATH_INFO patchset, whose purpose is to > reduce the use of CGI parameters by embedding as many parameters as > possible in the URL path itself, provided the pathinfo feature is > enabled. [...] > Giuseppe Bilotta (5): > gitweb: parse project/action/hash_base:filename PATH_INFO > gitweb: generate project/action/hash URLs > gitweb: use_pathinfo filenames start with / > gitweb: parse parent..current syntax from PATH_INFO > gitweb: generate parent..current URLs I like it, and with the exception of the last patch (which looks like it doesn't check if $file_name contains '..', even as it checks if $file_parent contains '..', and which probably should not esc_url) it looks OK. from (superficial) browsing through patches. I'll try to review them soon. -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
