2008/10/13 Johannes Sixt <j.sixt@xxxxxxxxxxxxx>: > Alex Riesen schrieb: >> I looked at the callers (briefly). Performance could be a problem: add >> and checkout can work with real big file lists and long pathnames. >> So ok, than. It is critical. > > You are kidding, aren't you? What you win by a few CPU instructions here > is dwarfed by the time that the stat() implementation requires. Dmitry, > please use the more readable tolower(). It is called for every element in a path, not just for every filename. And maybe it is dwarfed, but they both are part of the same operation. And this code makes it more CPU intensive. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
