Junio C Hamano wrote:
I was wondering if git_cygwin_config() was originally written not to call
git_default_config() because some command implementations do not to want
to call git_default_core_config() (and/or read trust_executable_bit
variable from the configuration) for some reason (which would be just
hiding bugs in other parts of the system, I suspect).
If that is the case, we would have to fix such broken parts of the system,
but until that happens your original patch to use a separate variable and
keeping trust_executable_bit untouched would be much safer than this
latest patch. Hence the question.
I was worried about altering the startup code, which is why I tried to
introduce as little change as possible. However, having rewritten the
patch using git_default_config() everything seems fine (the testsuite
passes, or at least as well as it usually does under Cygwin, and I
assume that is sufficient as this is Cygiwn specific). So, that patch
follows.
Mark
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
