On Tue, Oct 07, 2008 at 06:15:24PM +0200, Johannes Sixt wrote: > and that should be sufficient. I'm proposing this heuristics: > > * If only textconv is given, all porcelains pick it. > * If only command is given, all porcelains pick it. > * If both are given, then > - git log picks textconv. > - git show and git diff: > . if exactly one pathspec was given, pick command; > . otherwise pick textconv I am not 100% convinced that is sufficient, given Matthieu's other post. But I will not personally be using external diff at all, so I am hard pressed to come up with a counter example. > Plumbing never picks any of them, just like today, nor should git > format-patch. The are other porcelains that could be sorted into this > list, like git blame and (the summary line of) git commit. Actually, I think blaming a text-conv'd version would be useful (at least for my case). But cleary it should be optional, and probably defaulting to off. Once again, I think this is a good reason to move to an explicit diff option for "respect textconv" rather than relying on maybe or maybe not loading the config. > BTW, please don't take git-gui as an example that would lauch MS-Word on > each diff. (Neither would gitk.) Both rely on plumbing, and that's good. > gitk has a menu entry "External diff", where the diff.doc.command could be > hooked into. But they are both porcelain. So in theory, they could behave differently depending on what config is available (or if not them, some other third-party porcelain). But I was just responding to Matthieu's use-case, so I am not sure what exactly people prefer; I am lucky enough not to version any MS-Word documents at all. :) -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
