Jonas Fonseca <jonas.fonseca@xxxxxxxxx> wrote: > On Wed, Oct 1, 2008 at 03:31, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote: > > diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectLoader.java b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectLoader.java > > index 5282491..87e861f 100644 > > --- a/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectLoader.java > > +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/ObjectLoader.java > > @@ -105,7 +105,12 @@ protected void setId(final ObjectId id) { > > * @throws IOException > > * the object cannot be read. > > */ > > - public abstract byte[] getBytes() throws IOException; > > + public final byte[] getBytes() throws IOException { > > + final byte[] data = getCachedBytes(); > > + final byte[] copy = new byte[data.length]; > > + System.arraycopy(data, 0, copy, 0, data.length); > > + return data; > > + } > > If I understand correctly, shouldn't this return the copy variable? F&@!#*@#&@!#*@!@!&#@#@*@! Yes. :-) I think its already committed to master too. Can you send a patch along to fix, and point out how stupid I am? -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html