2008/10/9 Brandon Casey <casey@xxxxxxxxxxxxxxx>: > Many call sites use strbuf_init(&foo, 0) to initialize local strbuf variable > "foo" which has not been accessed since its declaration. These can be > replaced with a static initialization using the STRBUF_INIT macro which is > just as readable, saves a function call, and takes up fewer lines. > > Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx> > --- > > > This does the same thing for strbuf_init() that the last one did for memset(). > But it does this using a predefined interface (using the STRBUG_INIT macro), so next time strbuf changed, the code using it may be left as is. I didn't like the memset->zero-init, but I do like this one. It is a bit unclear, by the way, why strbuf_init wasn't inlined. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html