Shawn O. Pearce, Wed, Oct 08, 2008 08:02:57 +0200: > Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> wrote: > > On Tue, Oct 07, 2008 at 08:21:28AM +0200, Alex Riesen <raa.lkml@xxxxxxxxx> wrote: > > > Yes. Does it work? :) > > > > Yes, it does. I'm not sure how to test it from the testsuite, maybe > > redirect the output to a file and grep in it? It's ugly, that's why I > > did not do so, but if you think a testcase is a musthave for this > > feature then that's the way to go, I guess. > > Actually its not a bad way to test the feature. Normally we disable > progress if stdout is not a tty. If you redirect to a file then > -v should be needed to get anything at all on stderr. > > You may be able to just test the size of the file: > > git fetch -v ... >out 2>err && git clone > test -s err Right, but I don't think you need tests for progress bar. As a typical eye candy, it tends to change often enough to be too annoying to test. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
