Giuseppe Bilotta wrote: > On Tue, Oct 7, 2008 at 4:39 PM, Jakub Narebski <jnareb@xxxxxxxxx> wrote: > > Giuseppe Bilotta wrote: > > Wouldn't it be simpler and as good solution to just leave validation > > off evaluate_path_info() (well, of course except check_head_link() test), > > and allow it to be validated when assigning global 'params' variables? > > check_head_link() would be repeated for path_info links, but that > > should not affect performance much. > > Well, it does have a performance hit in the case of invalid $project > since it spends time working on the rest of the URL before bailing > out, but it's probably the cleanest solution. I'll do it this way. I have forgot about this fact, that parameter validation serves also as early escape. But I don't think it is much performance hit in practice; it is performance (optimization) vs. maintability tradeoff. -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
