Hi,
On Thu, 2 Oct 2008, David Bryson wrote:
>
> Signed-off-by: David Bryson <david@xxxxxxxxxxxxxxx>
>
> I tried to keep with the naming/coding conventions that I found in
> remote.c. Feedback welcome.
>
> ---
Usually this comment goes after the --- but other than that, the form is
as perfect as you can wish for.
> @@ -314,15 +315,15 @@ static int handle_config(const char *key, const char *value, void *cb)
> return 0;
> branch = make_branch(name, subkey - name);
> if (!strcmp(subkey, ".remote")) {
> - if (!value)
> - return config_error_nonbool(key);
> - branch->remote_name = xstrdup(value);
> + if (git_config_string(&v, key, value) )
> + return -1;
> + branch->remote_name = v;
What is the reason not to write
if (git_config_string(&branch->remote_name, key, value))
return -1;
? (Also note that we do not like the space between the two closing
parentheses.)
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
