On Sun, Oct 05, 2008 at 11:14:00AM +0200, Alex Riesen wrote: > 2008/10/5 Dmitry Potapov <dpotapov@xxxxxxxxx>: > > So, here is a patch. It basically disallow backslashes and colons in > > file names on Windows (whether it is MinGW or Cygwin). > > With this and sparse checkout patch combined it maybe possible > to make Git work on these backward filesystems in a saner way: > just never checkout the names which the filesystems cannot support > on disk and mark them correspondingly in the index. Perhaps, using sparse checkout is a good idea for dealing with prohibit characters, but the goal of my patch was a bit different -- to close a security hole in checkout when files outside of the working directory can be overwritten. In fact, the whole point of having verify_path() is to prevent this from happening, and if it does not work properly on Windows then this function should be corrected. Dmitry -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
