On Fri, Oct 03, 2008 at 07:28:42AM +0200 or thereabouts, Andreas Ericsson wrote:
> David Bryson wrote:
>> Signed-off-by: David Bryson <david@xxxxxxxxxxxxxxx>
>> I tried to keep with the naming/coding conventions that I found in
>> remote.c. Feedback welcome.
>> ---
>> remote.c | 19 ++++++++++---------
>> 1 files changed, 10 insertions(+), 9 deletions(-)
>> diff --git a/remote.c b/remote.c
>> index 3f3c789..893a739 100644
>> --- a/remote.c
>> +++ b/remote.c
>> @@ -305,6 +305,7 @@ static int handle_config(const char *key, const char
>> *value, void *cb)
>> {
>> const char *name;
>> const char *subkey;
>> + const char *v;
>
>
> Not very mnemonic. I'm sure you can think up a better name, even if it's
> a long one. Git is notoriously sparse when it comes to comments. We rely
> instead on self-explanatory code.
>
Oh I agree entirely, it is quite vague, however like I mentioned I tried
to keep to the conventios in the file. This strategy(v) is used in several
other places in remote.c, if this is Bad Code, then I have no problem
changing it.
Thoughts from anybody else ?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
