On Fri, 3 Oct 2008, Tuncer Ayaz wrote: > Following is a patch to complete the changes discussed > here http://marc.info/?l=git&m=121529226023180&w=2. > > I hope it makes sense and doesn't break something else. > > With this simple one-liner patch applied I no longer see > the following remote messages as no-progress is correctly > sent to the remote site: > remote: Counting objects: 84102, done. > remote: Compressing objects: 100% (24720/24720), done. > remote: Total 84102 (delta 60949), reused 80810 (delta 57900) > > Regards, > > Tuncer Ayaz > > Signed-off-by: Tuncer Ayaz <tuncer.ayaz@xxxxxxxxx> > --- > transport.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/transport.c b/transport.c > index 71433d9..1f24011 100644 > --- a/transport.c > +++ b/transport.c > @@ -644,7 +644,7 @@ static int fetch_refs_via_pack(struct transport *transport, > args.include_tag = data->followtags; > args.verbose = (transport->verbose > 0); > args.quiet = args.no_progress = (transport->verbose < 0); > - args.no_progress = !isatty(1); > + args.no_progress = args.quiet || !isatty(1); If you're doing that, remove the "args.no_progress =" from the previous line, which was there to have that effect (but not so clearly). Aside from that, it looks good to me. > args.depth = data->depth; > > for (i = 0; i < nr_heads; i++) > -- > 1.6.0.2 > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
