Hi, On Thu, 2 Oct 2008, Giuseppe Bilotta wrote: > On Thu, Oct 2, 2008 at 2:33 PM, Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > > On Thu, 2 Oct 2008, Giuseppe Bilotta wrote: > > > >> Set auto-number true by default, allowing the format.number key to be > >> set to 'noauto' to override this. > >> --- > >> builtin-log.c | 6 +++++- > >> 1 files changed, 5 insertions(+), 1 deletions(-) > > > > Interesting. No sign-off, no defense why this is actually desirable, > > after we lived for so long without this behavior... Care to elaborate? > > Doh, sorry about the Sign-off, I'll resend with. > > Now, about the reason for this patch: I would say that the most common > use-case of format-patch being used to prepare multiple patches is > when one plans on sending a patchset. When format.numbering is set to > auto, single-patches will still be extracted without numbers, but > patchset will be properly numbered. > > Of course, there may be cases where one doesn't want numbering (for > which there is the -N flag already), and of course we want to give the > user the choice to disable autonumbering at the config level, for > which there is the new noauto option for format.numbering. > > If this explanation is good enough for you, I'll plop it in the resend > message too :) Yep, this is worthy of a commit message. Thanks, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
