Raphael Zimmerer <killekulla@xxxxxxx> wrote: > diff --git a/builtin-grep.c b/builtin-grep.c > index 3a51662..2241324 100644 > --- a/builtin-grep.c > +++ b/builtin-grep.c > @@ -295,6 +295,9 @@ static int external_grep(struct grep_opt *opt, const char **paths, int cached) > push_arg("-l"); > if (opt->unmatch_name_only) > push_arg("-L"); > + if (opt->null_following_name) > + // in GNU grep git's "-z" translates to "-Z" > + push_arg("-Z"); We use /* */ style comments in Git. I've amended the patch with the simple // -> /* */ translation. The rest of this change looks good to me. Its queued for next. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html