Hi Shawn, On Tue, Sep 30, 2008 at 12:04:49PM -0700, Shawn O. Pearce wrote: > Uwe Kleine-KKKnig <ukleinek@xxxxxxxxx> wrote: > > On Mon, Sep 29, 2008 at 08:01:27AM -0700, Shawn O. Pearce wrote: > > > --tags:: > > > If a lightweight tag exactly matches, output it. If no > > > annotated tag is found in the ancestry but a lightweight > > > tag is found, output the lightweight tag. > > > > IMHO --tags should behave as Erez expected (because it's what I > > expected, too). As --tags currently behaves it's only usable in very > > rare cases (most of the time it only makes a difference on repos without > > any annotated tag). > > > > When do you pass --tags? Only if a lightweight tag is OK for an answer. > > And then I would prefer a "near" lightweight tag to a "farer" annotated > > one. > > I don't disagree. I've been tempted to write a patch to change the > behavior of git-describe so that --tags and --all control what names > are inserted into the candidate list, but don't control the ordering > of their selection. > > I think this is all that is needed to make the behavior do what you > and Erez expected. But its a pretty big change in the results if > you are passing in --all or --tags today. But it matches the documentation, and the expectations of Erez, me and (at least initially) Pierre. My POV is still: If you pass --all or --tags you have to be able to handle if a lw tag is used in the answer. > -static int all; /* Default to annotated tags only */ > -static int tags; /* But allow any tags if --tags is specified */ > +static int all; /* Any valid ref can be used */ > +static int tags; /* Either lightweight or annotated tags */ Mmmh, IMHO the comment for tags is misleading, its either annotated only or both. Best regards and thanks, Uwe -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
