On Tue, Sep 30, 2008 at 12:29:01PM +0200, Johannes Sixt wrote: > Andreas Ericsson schrieb: > > Jeff King wrote: > >> - if ! grep -qe "Invalid gitfile format" .err > >> + if ! grep "Invalid gitfile format" .err > > > > Doesn't output need to be redirected when you drop '-q'? > > In standard mode, the test output is directed to /dev/null anyway, and in > verbose mode the extra output doesn't hurt at all, and is usually useful > because you know that a pattern matched. Exactly. This is the more of the same as aadbe44f (grep portability fix: don't use "e" or "-q") but I was too lazy to rewrite the justification completely (but I did reference it). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
