On Mon, 29 Sep 2008, Giuseppe Bilotta wrote:
> On Mon, Sep 29, 2008 at 3:08 AM, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
>> On Sun, 21 Sep 2008, Giuseppe Bilotta wrote:
>>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>>> index e783d12..18da484 100755
>>> --- a/gitweb/gitweb.perl
>>> +++ b/gitweb/gitweb.perl
>>> @@ -664,7 +664,7 @@ sub href (%) {
>>> if (defined $params{'hash_base'}) {
>>> $href .= "/".esc_url($params{'hash_base'});
>>> if (defined $params{'file_name'}) {
>>> - $href .= ":".esc_url($params{'file_name'});
>>> + $href .= ":/".esc_url($params{'file_name'});
>>> delete $params{'hash'} if $params{'hash'} eq git_get_hash_by_path($params{'hash_base'},$params{'file_name'});
>>> delete $params{'file_name'};
>>> } else {
>>> --
>>> 1.5.6.5
>>
>> Is there reason why this change is separate (not squashed) from
>> previous commit?
>
> Historical reason (i.e. I came up with the idea later on). I'll squash it.
Hn. Now I am not sure if it should be squashed, or should be separate.
Good change.
Please don't forget to describe this decision, i.e. why gitweb is
using "branch:/filename" when creating path_info links instead of
simple "branch:name" for relative URLs in HTML in 'raw' ('blob_plain')
view, in the commit message. Thanks in advance.
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
