On Thu, Sep 25, 2008 at 4:51 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote: > Petr Baudis <pasky@xxxxxxx> wrote: >> On Thu, Sep 25, 2008 at 01:48:37PM +0200, Thomas Rast wrote: >> > Nanako Shiraishi wrote: >> > > This removes three functions that are not used anywhere. >> > [...] >> > > -void set_usage_routine(void (*routine)(const char *err) NORETURN) >> > > -void set_error_routine(void (*routine)(const char *err, va_list params)) >> > > -void set_warn_routine(void (*routine)(const char *warn, va_list params)) >> > >> > These blame to the following commit: >> > >> > commit 39a3f5ea7c0352a530338d30d4e618f6b4db84e4 >> > Author: Petr Baudis <pasky@xxxxxxx> >> > >> > Customizable error handlers > ... >> > So apparently the intent was that they would only be used from outside >> > Git. I don't know whether anyone still plans to do that, but they're >> > certainly not "just" unused. >> >> I don't think it will be a big deal to remove these functions, though it >> does feel like a little bit of a step backwards in the libgit efforts. >> There are some programs that already link to Git, like CGit - I wonder >> if some of them don't use them (CGit itself doesn't). > > IMHO these are useless for a "libgit". However both tig and > cgit link to the non-existant libgit.a, so they may be using > these routines. I've CC'd their authors and am not applying this > particular change without an ACK from them. Sorry for the late reply. And no, cgit doesn't use these functions and I don't think that's going to change, so Acked-by: Lars Hjemli <hjemli@xxxxxxxxx> -- larsh -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
